Update app instance cell data when scaling up #3133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Oct 17, 2018
•
richard-cox
commented
- Every time we scale up app instances we now refresh the data we use to determine which cell the app instance is in
- This helps avoid situations where user scales down and then scales up and old instance cell data is used
- Unfortunately the firehose only emits this information every 60 seconds, so if the scale down + up happens within this time the old data is still used. There's not much we can do about this without lots of code
- fixes Clear metrics used to show app instance cell when scaling #3126
- Every time we scale up app instances we now refresh the data we use to determine which cell the app instance is in - This helps avoid situations where user scales down and then scales up and old instance cell data is used - Unfortunately the firehose only emits this information every 60 seconds, so if the scale down + up happens within this time the old data is still used. There's not much we can do about this without lots of code
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3133 +/- ##
=============================================
- Coverage 71.09% 71.08% -0.02%
=============================================
Files 632 632
Lines 27752 27771 +19
Branches 6314 6317 +3
=============================================
+ Hits 19731 19741 +10
- Misses 8021 8030 +9 |
nwmac
suggested changes
Oct 19, 2018
richard-cox
added
comments-addressed
and removed
needs attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.