Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'type text to continue' to confirmation modal #3131

Merged
merged 8 commits into from
Oct 30, 2018
Merged

Conversation

richard-cox
Copy link
Contributor

Wired in to delete of service instance, org and space
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Oct 16, 2018

Codecov Report

Merging #3131 into v2-master will decrease coverage by 24.77%.
The diff coverage is 65.9%.

@@              Coverage Diff               @@
##           v2-master    #3131       +/-   ##
==============================================
- Coverage      71.11%   46.33%   -24.78%     
==============================================
  Files            630      630               
  Lines          27572    27587       +15     
  Branches        6270     6274        +4     
==============================================
- Hits           19608    12783     -6825     
- Misses          7964    14804     +6840

@KlapTrap KlapTrap merged commit aba5960 into v2-master Oct 30, 2018
@richard-cox richard-cox deleted the type-to-delete branch October 30, 2018 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When deleting certain entities force user to input name of entity
3 participants