Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where app status showed old info after successful deploy #3115

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Fix issue where app status showed old info after successful deploy #3115

merged 1 commit into from
Oct 8, 2018

Conversation

richard-cox
Copy link
Contributor

  • Deploy an app and wait for the Deployed status
  • Exit the stepper.. previously the state was stale
  • We now fetch the app when exiting stepper to ensure the app package_state is up to date
  • This results in the app 'fetching' indicator being shown.. then the summary tab with the correct state
  • Note - the only functional change is the dispatch in DeployApplicationStep3Component, everything else is tidying up

@richard-cox
Fix issue where app status showed old info after successful deploy
9d617d5 
- Deploy an app and wait for the `Deployed` status
- Exit the stepper.. previously the state was stale
- We now fetch the app when exiting stepper to ensure the app package_state is up to date
- This results in the app 'fetching' indicator being shown.. then the summary tab with the correct state
- Note - the only functional change is the dispatch in DeployApplicationStep3Component, everything else is tidying up
@richard-cox richard-cox self-assigned this Oct 5, 2018
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #3115 into v2-master will decrease coverage by <.01%.
The diff coverage is 80%.

@@              Coverage Diff              @@
##           v2-master    #3115      +/-   ##
=============================================
- Coverage      71.17%   71.16%   -0.01%     
=============================================
  Files            627      627              
  Lines          27412    27407       -5     
  Branches        6229     6229              
=============================================
- Hits           19510    19504       -6     
- Misses          7902     7903       +1

nwmac
nwmac approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 8b95e8e into v2-master Oct 8, 2018
@nwmac nwmac deleted the fix-app-state-on-deploy branch October 8, 2018 07:38
@aegershman
Copy link
Contributor

screen shot 2018-10-08 at 11 23 50 pm

Congrats on this being the 10,000th commit.

... Yaaaaay 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richard-cox @cfdreddbot @aegershman @nwmac