CF Cells #3099
Merged
CF Cells #3099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Oct 2, 2018
richard-cox
commented
- Depends on Improve application metrics #3010
- Adds..
- cell column to app instances table
- cells tab to cf page
- cell view with summary and charts tabs
- Requires metrics endpoint for apps cf - Includes lots of tidy up encountered on the way - Depends on entityService.. which requires IRequestAction.. so MetricsAction now imlements it - Fixed instance of IMetricsData typing
…o cf-cell-summary
…o cf-cell-summary
- ensure we associated correct cell with instance by instance_index - if cell info is missing for instance poll until we have it
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
richard-cox
changed the base branch from
v2-master
to
improve-application-metrics
richard-cox
changed the base branch from
improve-application-metrics
to
v2-master
* v2-master: Fix create org, nav to org exception - When we fetch an org we check if any user is missing any roles collection (there's too many too show) - During this check we assumed the org will always have the users - For the case of a new org there are no users Test for the org/space create failure
Codecov Report
@@ Coverage Diff @@
## v2-master #3099 +/- ##
============================================
Coverage ? 71.17%
============================================
Files ? 624
Lines ? 27247
Branches ? 6184
============================================
Hits ? 19394
Misses ? 7853
Partials ? 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.