Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagnostics does not show GitHub details when cloned via HTTPS #3007

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Sep 17, 2018

Fixes #3006

@nwmac nwmac self-assigned this Sep 17, 2018
@nwmac nwmac requested a review from richard-cox September 17, 2018 14:03
@cfdreddbot
Copy link

Hey nwmac!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Sep 17, 2018

Codecov Report

Merging #3007 into v2-master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##           v2-master   #3007      +/-   ##
============================================
- Coverage      71.03%     71%   -0.03%     
============================================
  Files            607     607              
  Lines          26246   26250       +4     
  Branches        5937    5939       +2     
============================================
- Hits           18643   18639       -4     
- Misses          7603    7611       +8

@nwmac nwmac changed the title Fix Git diagnostics bug Diagnostics does not show GitHub details when cloned via HTTPS Sep 17, 2018
@richard-cox richard-cox merged commit 6350c84 into v2-master Sep 17, 2018
@richard-cox richard-cox deleted the git-diagnostics-fix branch September 17, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants