Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSO: Refinements #2982

Merged
merged 1 commit into from
Sep 13, 2018
Merged

SSO: Refinements #2982

merged 1 commit into from
Sep 13, 2018

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Sep 13, 2018

Minor SSO refinements:

  • Fix consistency of SSO casing and hyphenation => 'Single Sign-On'
  • Make SSO default when connecting if enabled for the endpoint
  • Move the SSO Allowed checkbox to the bottom in 'Advanced Options', so that the form does not move when the checkbox is checked and the advisory text appears

@cfdreddbot
Copy link

Hey nwmac!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@nwmac nwmac self-assigned this Sep 13, 2018
@nwmac nwmac requested a review from richard-cox September 13, 2018 12:32
@codecov
Copy link

codecov bot commented Sep 13, 2018

Codecov Report

Merging #2982 into v2-master will increase coverage by 0.02%.
The diff coverage is 33.33%.

@@              Coverage Diff              @@
##           v2-master    #2982      +/-   ##
=============================================
+ Coverage         71%   71.03%   +0.02%     
=============================================
  Files            607      607              
  Lines          26243    26246       +3     
  Branches        5935     5937       +2     
=============================================
+ Hits           18635    18643       +8     
+ Misses          7608     7603       -5

@richard-cox richard-cox merged commit caa08f9 into v2-master Sep 13, 2018
@richard-cox richard-cox deleted the sso-tweak branch September 13, 2018 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

Assignees

@nwmac nwmac

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwmac @cfdreddbot @richard-cox