Hey irfanhabib!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

Codecov Report

Merging #2959 into v2-master will decrease coverage by 0.03%.
The diff coverage is 50%.

@@              Coverage Diff              @@
##           v2-master    #2959      +/-   ##
=============================================
- Coverage      71.13%   71.09%   -0.04%     
=============================================
  Files            632      632              
  Lines          27683    27768      +85     
  Branches        6297     6314      +17     
=============================================
+ Hits           19691    19742      +51     
- Misses          7992     8026      +34

@nwmac Updated the PR to handle missing amount more gracefully

thanks @irfanhabib

Is there a mapping between the spec unit field https://github.com/openservicebrokerapi/servicebroker/blob/master/profile.md#cost-object with examples such as "MONTHLY", "HOURLY", "Request", "GB" and the actual label displayed in the UI, which in the screenshot shows as "Month" ? Can you point me to this mapping logic (as I couldn't easily review it) ?

The service catalogs from PWS marketplace, seems to indeed stick to spec example and use the "MONTHLY" unit string.

$ CF_TRACE=true cf m -s elephantsql | grep costs
        "extra": "{\"displayName\":\"Tiny Turtle\",\"bullets\":[\"Shared high performance cluster\",\"20 MB data\",\"4 concurrent connections\"],\"costs\":[{\"amount\":{\"usd\":0},\"unit\":\"MONTHLY\"}]}",
        "extra": "{\"displayName\":\"Pretty Panda\",\"bullets\":[\"Shared high performance cluster\",\"2 GB data\",\"20 concurrent connections\"],\"costs\":[{\"amount\":{\"usd\":19.0},\"unit\":\"MONTHLY\"}]}",
        "extra": "{\"displayName\":\"Happy Hippo\",\"bullets\":[\"Dedicated server\",\"100 GB data\",\"1.7 GB RAM\",\"300 concurrent connections\"],\"costs\":[{\"amount\":{\"usd\":99.0},\"unit\":\"MONTHLY\"}]}",
        "extra": "{\"displayName\":\"Enormous Elephant\",\"bullets\":[\"Dedicated server\",\"7.5 GB RAM\",\"1000 GB data\",\"EBS optimized, 500 Mbps\",\"300 concurrent connections\"],\"costs\":[{\"amount\":{\"usd\":499.0},\"unit\":\"MONTHLY\"}]}",

I'm wondering whether a label such as the following would better accommodate the current specs, including the prefix/postfix display variation depending on currencies.

Cost (unit=$unit currency=$currency): $amount
e.g.

• Cost (unit=monthly currency=Euro): 10
• Cost (unit=hourly currency=USD): 20
• Cost (unit=hour currency=USD): 20
• Cost (unit=GB currency=GBP): 10
• Cost (unit=1,000 API calls currency=Euro): 10.5

Alternative: Cost : $amount ($currency , $unit)

• Cost: : 10 (Euro, monthly)
• Cost: 20 (USD, hourly)
• Cost: 20 (GBP, GB)
• Cost: 10.5 (Euro, 1,000 API calls)

It's less nice looking, but might be more accurate (without going into complex wording logic).

@gberche-orange The code is agnostic to what the actual unit in question is. It can be anything (month, GB etc..)

In the example you'be provided, for example, the card would show the following:

Cost (unit=1,000 API calls currency=Euro): 10.5 => Cost per 1,000 API calls: ..

@irfanhabib with the unit example of the OSB specifications where the unit example is MONTHLY and with a currency set to EUR, would the price then be displayed as Cost per MONTHLY: EUR 10 (which would be grammatically odd, and EUR currency commonly expected to be located after the digits)

This unusual wording is to be compared with an alternative display such as Cost (unit=MONTHLY currency=EUR): 10.5 which might be harder to read in common cases, but more friendly to non USD units, and specified currency units.

@gberche-orange I've changed the format to:

Cost per UNIT In CURRENCY

I.e

@gberche-orange
A final change, the cost + currency is shown in the European format, if the currency is Euro.

Otherwise it defaults to American English format

@irfanhabib looks great, thanks. I guess the currency logic (prefix vs suffix) can be extended in the future with other currencies (e.g. yens...)

@irfanhabib Should we remove the Free: false is there is a cost shown?

For testing, IBM has some funky pricing. See Cloudant service

I've tweaked the output after reviewing. It looked like we were displaying the MONTHLY unit text after all. Given the new changes the example costs object from the open service broker docs would look like...

The format of the currency value remains unchanged (0.99EUR or [others]0.99). We'll update this when we implement i18n.
I've tested this on PWS and it looks good. For IBM we won't show costs at all (their pricing structure is more complex and I'd rather not show anything at all than something that's incorrect).
@gberche-orange If you're happy with the new format I'll get this merged once it's passed our CI

thanks @richard-cox, this seems a good balance to me