Harden app delete e2e test to reduce chance of concurrency failures #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2942 +/- ##
==========================================
Coverage 71.35% 71.35%
==========================================
Files 605 605
Lines 25894 25894
Branches 5872 5872
==========================================
Hits 18477 18477
Misses 7417 7417 |
nwmac
reviewed
Sep 3, 2018
| let appCount = 0; | ||
| appWall.appList.getTotalResults().then(count => appCount = count); | ||
| appWall.appList.header.setSearchText(testAppName); | ||
| expect(appWall.appList.getTotalResults()).toBe(1); | ||
|
|
||
| e2e.sleep(5000); |
There was a problem hiding this comment.
I know these aren't due to your PR - but why do we have two 5s delays ? We should avoid using sleep... we must be waiting for something, so we should wait for it.
src/test-e2e/login/login-e2e.spec.ts
Outdated
| @@ -16,7 +16,7 @@ describe('Login', () => { | |||
|
|
|||
| it('- should reach log in page', () => { | |||
| expect(loginPage.isLoginPage()).toBeTruthy(); | |||
| expect<any>(loginPage.getTitle()).toEqual('STRATOS'); | |||
| expect<any>(loginPage.getTitle()).toEqual(''); | |||
There was a problem hiding this comment.
Can we remove this altogether - it won't work on forks, if they unhide the title.
- Removed two of the original sleeps. These have been in since the begining of the e2e tests, not sure why. Have removed them and tested against capbristol. - Removed check for empty login title text. Whilst handy for vanila stratos it will break downstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2943