Extend endpoint registration UI to support Client ID and Client Secret #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey nwmac! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2920 +/- ##
=============================================
- Coverage 46.73% 46.72% -0.02%
=============================================
Files 607 607
Lines 26169 26180 +11
Branches 5926 5930 +4
=============================================
+ Hits 12230 12232 +2
- Misses 13939 13948 +9 |
This was referenced Aug 30, 2018
Closed
richard-cox
approved these changes
Sep 10, 2018
- Show redirect_uri message underneath sso checkbox - Merge with new optional client id/secret section split these two components - Text for redirect_uri is now limited by form, alernative is to place SSO under optional section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to specify the Client ID and Client Secret to use when registering an endpoint.
The back-end changes are already in place for this, so this PR adds the necessary fields into the UI