Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalability: Change application list in service instance table row from vertical to chip list #2915

Merged
merged 5 commits into from
Sep 11, 2018

Conversation

richard-cox
Copy link
Contributor

@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@richard-cox richard-cox self-assigned this Aug 28, 2018
@KlapTrap KlapTrap added needs attention This PR needs attention and removed ready for review labels Aug 31, 2018
@richard-cox richard-cox added ready for review and removed needs attention This PR needs attention labels Sep 3, 2018
@codecov
Copy link

codecov bot commented Sep 3, 2018

Codecov Report

Merging #2915 into v2-master will increase coverage by 0.01%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##           v2-master    #2915      +/-   ##
=============================================
+ Coverage      71.35%   71.37%   +0.01%     
=============================================
  Files            605      605              
  Lines          25894    25908      +14     
  Branches        5872     5872              
=============================================
+ Hits           18477    18491      +14     
  Misses          7417     7417

@nwmac nwmac self-requested a review September 11, 2018 16:36
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 0fdbaaa into v2-master Sep 11, 2018
@nwmac nwmac deleted the bound-apps-chip-list branch September 11, 2018 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants