Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalability: Convert space apps list from local to remote #2913

Merged
merged 3 commits into from
Sep 12, 2018

Conversation

richard-cox
Copy link
Contributor

fixes #2893

@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #2913 into v2-master will increase coverage by 0.02%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##           v2-master    #2913      +/-   ##
=============================================
+ Coverage      71.31%   71.34%   +0.02%     
=============================================
  Files            604      604              
  Lines          25868    25868              
  Branches        5861     5860       -1     
=============================================
+ Hits           18449    18455       +6     
+ Misses          7419     7413       -6

@KlapTrap KlapTrap self-requested a review August 31, 2018 15:16
* v2-master: (95 commits)
  This week;s updates
  Update following review
  Remove fdescribe
  Fix broken e2e tests [e2e]
  Don't need AWS CLI
  Test bump [e2e]
  Enable app deply e2e test
  Fix application deploy For request params ensure xGUID -> xGuid
  Reinstate all tests
  Run through with tests
  Final fix.
  Test
  Last time
  Debug
  Debug
  Bug fix
  Speed up test report debug
  Set insecure flag
  Temporarily disable app deploy test - see #2930
  Use minio client
  ...
@codecov
Copy link

codecov bot commented Aug 31, 2018

Codecov Report

Merging #2913 into v2-master will increase coverage by 0.93%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##           v2-master    #2913      +/-   ##
=============================================
+ Coverage      70.42%   71.35%   +0.93%     
=============================================
  Files            594      605      +11     
  Lines          25135    25894     +759     
  Branches        5675     5871     +196     
=============================================
+ Hits           17701    18477     +776     
+ Misses          7434     7417      -17

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 37a52e3 into v2-master Sep 12, 2018
@nwmac nwmac deleted the non-local-space-apps branch September 12, 2018 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scalability: Convert space apps list from local to remote
4 participants