Update cache-control header #2910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Static files served via backed (AIO + cf push world) should have `cache-control: no-cache` - IE caches some https content, therefore jetstream shouldn't cache any requests `cache-control: no-store`
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2910 +/- ##
==========================================
Coverage 71.35% 71.35%
==========================================
Files 604 604
Lines 25857 25857
Branches 5855 5855
==========================================
Hits 18449 18449
Misses 7408 7408 |
nwmac
suggested changes
Aug 24, 2018
There was a problem hiding this comment.
Not sure that the logic here is correct.
Surely we want to allow the browser to cache the application (static resources) - so that it doesn't have to download the app each time?
Isn't it the non-static resources - i.e. the API requests that we don't want it to cache/store ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cache-control: no-cachecache-control: no-storeAddresses half of #2807