Harden the service wall instance card #2908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Aug 24, 2018
richard-cox
commented
- Ensure we only show the template, which requires serviceInstanceEntity, when we have it
- Removed ServicesWallService provider, it's not used (ctor never called)
- Removed/Sorted imports
- Fixes I can not get service information #2814
- Ensure we only show the template, which requires serviceInstanceEntity, when we have it - Removed ServicesWallService provider, it's not used (ctor never called) - Removed/Sorted imports
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2908 +/- ##
=============================================
- Coverage 71.35% 71.34% -0.01%
=============================================
Files 604 604
Lines 25857 25856 -1
Branches 5855 5855
=============================================
- Hits 18449 18448 -1
Misses 7408 7408 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.