Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to simplify dev experience with go backend #2861

Merged
merged 16 commits into from
Aug 28, 2018
Merged

Improvements to simplify dev experience with go backend #2861

merged 16 commits into from
Aug 28, 2018

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Aug 21, 2018 •
edited
Loading

This PR makes a few changes to make it easier to get started with backend dev and includes a few tidy ups:

  • Remove backend-dev target
  • Fix all in one so it only builds backend once and uses the jetstream exe as is
  • Update Cloud Foundry deployment to use the jetstream exe as is
  • Fix panic if there is no config file due to missing encryption key config
  • Allow folder for UI static resources to be configured
  • Add support for a default config file which will work for dev

@nwmac nwmac self-assigned this Aug 21, 2018
@cfdreddbot
Copy link

Hey nwmac!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Aug 22, 2018 •
edited
Loading

Codecov Report

Merging #2861 into v2-master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           v2-master    #2861   +/-   ##
==========================================
  Coverage      71.34%   71.34%           
==========================================
  Files            604      604           
  Lines          25868    25868           
  Branches        5861     5861           
==========================================
  Hits           18455    18455           
  Misses          7413     7413

@irfanhabib irfanhabib self-requested a review August 28, 2018 12:03
@irfanhabib irfanhabib merged commit 93984c6 into v2-master Aug 28, 2018
@irfanhabib irfanhabib deleted the go-fixes branch August 28, 2018 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irfanhabib irfanhabib Awaiting requested review from irfanhabib

Assignees

@nwmac nwmac

Labels
in review ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwmac @cfdreddbot @irfanhabib