Upgrade angular to 6.1.1 to fix security vulnerability #2850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey irfanhabib! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
added 2 commits
August 17, 2018 20:53
Codecov Report
@@ Coverage Diff @@
## v2-master #2850 +/- ##
=============================================
+ Coverage 71.35% 71.35% +<.01%
=============================================
Files 604 604
Lines 25857 25859 +2
Branches 5855 5859 +4
=============================================
+ Hits 18449 18452 +3
+ Misses 7408 7407 -1 |
KlapTrap
suggested changes
Aug 21, 2018
| @@ -68,12 +68,13 @@ export class CurrentUserPermissionsChecker { | |||
| filter(state => !!state), | |||
| map(state => { | |||
| const permissionString = permission as PermissionStrings; | |||
| let orgOrSpaceState; | |||
There was a problem hiding this comment.
We should rename the variable rather than using let here.
| @@ -122,6 +122,7 @@ export class DeployApplicationStep2Component | |||
| this.stepperText = 'Review source details'; | |||
| } | |||
|
|
|||
| let action; | |||
There was a problem hiding this comment.
Again, we should try to avoid using let.
| const filterStoreToWidget = this.paginationController.filter$.pipe(tap((filter: ListFilter) => { | ||
| this.filterString = filter.string; | ||
| this.multiFilters = { ...filter.items }; | ||
| const filterStoreToWidget = this.paginationController.filter$.pipe(tap((f: ListFilter) => { |
There was a problem hiding this comment.
Can we rename f to paginationFilter? Just to be a little more explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2851
This updates to angular 6.1.1 (from 6.0.3). The dependency that introduced the security vulnerability was imported by @angular-devkit/build-angular and is fixed by 0.7.4.