Add restage to application page. #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey KlapTrap! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2828 +/- ##
==============================================
- Coverage 71.16% 46.77% -24.39%
==============================================
Files 607 607
Lines 26131 26140 +9
Branches 5915 5917 +2
==============================================
- Hits 18596 12228 -6368
- Misses 7535 13912 +6377 |
nwmac
previously requested changes
Aug 14, 2018
| <button mat-icon-button name="cli" routerLink="/applications/{{applicationService.cfGuid}}/{{applicationService.appGuid}}/cli" matTooltip="CLI Info"> | ||
| <mat-icon>keyboard</mat-icon> | ||
| <ng-template #startButton> | ||
| <button mat-icon-button name="start" [disabled]="busy.updating || !appState.actions.start && !appState.actions.stop" (click)="startApplication()" matTooltip="Start"> |
There was a problem hiding this comment.
I think start button should only be disabled if start is not allowed - [disabled]="busy.updating || !appState.actions.start".
| @@ -1,12 +1,5 @@ | |||
| <app-page-header [breadcrumbs]="breadcrumbs$ | async"> | |||
| <h1>CLI Info</h1> | |||
| <div class="page-header-right"> | |||
There was a problem hiding this comment.
There are other places where we have the close button, so we should be consistent and remove them there too.
| @@ -62,7 +59,7 @@ export class CliInfoApplicationComponent implements OnInit { | |||
| this.route$ = this.store.select(getPreviousRoutingState).pipe( | |||
| map(route => { | |||
| return { | |||
| url: route && route.state ? route.state.url : defaultBackLink, | |||
There was a problem hiding this comment.
With the close button removed, you can remove the back() method, setupRouteObservable, defaultBackLink etc - these were only there to find the back URL - we are always going back to the summary tab now, so not needed.
* v2-master: (149 commits) Test bump [e2e] Enable app deply e2e test Fix application deploy For request params ensure xGUID -> xGuid Temporarily disable app deploy test - see #2930 Add additional logging Fix jetstream output Updates following review Fix README buttons after merge Fix code cov button Fix CF Console client [e2e] Check in travis E2E config for jetstream [e2e] Update package.json [e2e] Update docker-compose & Travis e2e script [e2e] Increase mem for standard `build` Enabled secure cookie for VCapApplication apps Pin dependency to new version of sqlitestore - cookie fix Update cache-control values - Static files served via backed (AIO + cf push world) should have `cache-control: no-cache` - IE caches some https content, therefore jetstream shouldn't cache any requests `cache-control: no-store` Weekly update Harden the service wall instance card - Ensure we only show the template, which requires serviceInstanceEntity, when we have it - Removed ServicesWallService provider, it's not used (ctor never called) - Removed/Sorted imports Ensure golint is installed ...
* v2-master: Remove fdescribe Fix broken e2e tests [e2e] Update build.sh Update concourse pipelines Update helm chart Add readme Update requiremens Add Metrics chart
KlapTrap
added
ready for review
and removed
needs attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2577