Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict non-admin user functions at cf level #2654

Merged
merged 12 commits into from
Jul 16, 2018
Merged

Restrict non-admin user functions at cf level #2654

merged 12 commits into from
Jul 16, 2018

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Jul 5, 2018 •
edited
Loading

Blocked on #2651 and #2659

  • When there are lots of orgs a non-admin user at the cf level should not be able to change roles or view users.
  • This is due to non-admins being unable to fetch all users via the users/ endpoint, so we fall back on fetching users from each org. For large amounts of orgs this severely restricts console usability.
  • The users table, which all previously worked on the same users data, will now behave slightly different in the above case. Org ans Space level tables will use the GetAllOrgUsers (with it's own pagination key) instead

@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Jul 6, 2018 •
edited
Loading

Codecov Report

Merging #2654 into v2-master will decrease coverage by 0.06%.
The diff coverage is 47.24%.

@@              Coverage Diff              @@
##           v2-master    #2654      +/-   ##
=============================================
- Coverage      47.95%   47.88%   -0.07%     
=============================================
  Files            597      597              
  Lines          25340    25396      +56     
  Branches        5735     5750      +15     
=============================================
+ Hits           12151    12161      +10     
- Misses         13189    13235      +46

@nwmac nwmac requested a review from KlapTrap July 16, 2018 10:01
KlapTrap added 2 commits July 16, 2018 16:17
@KlapTrap
Minor tidy ups
6a4c387
@KlapTrap
Merge branch 'v2-master' into fix-non-admin-many-users-3
5085f33 
* v2-master:
  Weekly status update
  Fix merge conflict
  Fixed typo
  Status update
  Organize imports
  Fix tests and lint
  Fix CF Delay
  Remove unused afterviewinit
  Fix create org and creats space validation
  Use correct log level
  Add Dashboard URL to services view
@KlapTrap KlapTrap merged commit b7b5c88 into v2-master Jul 16, 2018
@KlapTrap KlapTrap deleted the fix-non-admin-many-users-3 branch July 16, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KlapTrap KlapTrap Awaiting requested review from KlapTrap

Assignees
No one assigned
Labels
blocked-pr ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-cox @cfdreddbot @KlapTrap