Don't validate individual org users requests #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…via individal org users call - 100 org user calls - might be same users returned every time, which are missing same set - 100 * 1-6 = lots of spam - Don't validate each response, leave to pagination sections to validate properly
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2651 +/- ##
=============================================
- Coverage 47.94% 47.93% -0.01%
=============================================
Files 597 597
Lines 25342 25345 +3
Branches 5724 5735 +11
=============================================
Hits 12149 12149
- Misses 13193 13196 +3 |
richard-cox
added
ready for review
blocked-pr
and removed
in progress
ready for review
labels
* v2-master: Fixed repeated org name on permission pills Tidy up safe observable code Fix unmap route action removing route from all lists Revert "Fix unmap route action removing route from all lists" Fix unmap route action removing route from all lists Select current service plan Fix unit tests Tidy up code Tidy up Fix edit of service instances Typo Update pagination if entities update Add column name tests Column names table unit tests Fixed linting Use better test reporter Ensure we don't recursively delete with the action is an update Ensure we don't show incorrect space roles in org users list - When there are many space roles we have to fetch them asyncronously - Previously the org users list would briefly show all space roles (even those for spaces not in org) before showing correct list - We now block until we have that space list - CF user and space user lists should remain unaffected Improve efficiency of calculating user other roles - Need to determine if a user has roles other than org user (to determine if we show the 'cross' on org user pill) - This happens per org user cell per user quite a lot of times - Previously this recalculated roles for each space and org. these could be 100s * above - Now we just check the user's arrays Ensure users with 100+ roles are stored correctly - admin with 100+ manager and dev space roles - we notice that the user is missing the manager and space properties and go out and fetch - previously we then stored the users managed spaces in the `spaces` property instead of `managed_spaces`
KlapTrap
suggested changes
Jul 6, 2018
| // initialParams = { | ||
| // page: 1, | ||
| // 'results-per-page': 100, | ||
| // 'order-direction': 'desc', |
KlapTrap
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably best to test after #2613 has merged.
Don't validate individual org users requests when fetching all users via individual org users call
the orgs users (these can contain duplicated users)