Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DB schema and backend to support storing a client/secret for each Endpoint - v2 #2622

Merged

Conversation

andrewghobrial
Copy link
Contributor

@andrewghobrial andrewghobrial commented Jul 3, 2018

This v2 of #2269, plus bug fixes.

Update: Now includes passing tests

@cfdreddbot
Copy link

Hey andrewghobrial!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@andrewghobrial andrewghobrial changed the title Multiple clients v2 Change DB schema and backend to support storing a client/secret for each Endpoint - v2 Jul 3, 2018
@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #2622 into v2-master will decrease coverage by 22.03%.
The diff coverage is 41.75%.

@@              Coverage Diff               @@
##           v2-master    #2622       +/-   ##
==============================================
- Coverage      69.97%   47.93%   -22.04%     
==============================================
  Files            595      597        +2     
  Lines          25235    25345      +110     
  Branches        5700     5735       +35     
==============================================
- Hits           17657    12149     -5508     
- Misses          7578    13196     +5618

@nwmac nwmac changed the base branch from v2-master to client-id-secret-db-support July 26, 2018 08:22
@nwmac nwmac changed the base branch from client-id-secret-db-support to v2-master July 26, 2018 08:24
@nwmac nwmac changed the base branch from v2-master to client-id-secret July 26, 2018 08:26
@nwmac nwmac merged commit e418ae4 into cloudfoundry:client-id-secret Jul 26, 2018
@andrewghobrial andrewghobrial deleted the multiple-clients-v2 branch August 16, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants