Fix three issues around 100+ roles #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- admin with 100+ manager and dev space roles - we notice that the user is missing the manager and space properties and go out and fetch - previously we then stored the users managed spaces in the `spaces` property instead of `managed_spaces`
- Need to determine if a user has roles other than org user (to determine if we show the 'cross' on org user pill) - This happens per org user cell per user quite a lot of times - Previously this recalculated roles for each space and org. these could be 100s * above - Now we just check the user's arrays
- When there are many space roles we have to fetch them asyncronously - Previously the org users list would briefly show all space roles (even those for spaces not in org) before showing correct list - We now block until we have that space list - CF user and space user lists should remain unaffected
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2613 +/- ##
==============================================
- Coverage 70.02% 47.94% -22.09%
==============================================
Files 595 597 +2
Lines 25215 25342 +127
Branches 5694 5724 +30
==============================================
- Hits 17657 12149 -5508
- Misses 7558 13193 +5635 |
This was referenced Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing would advice using
deploy/tools/populate-cf/create-many-spaces.shEnsure users with 100+ roles are stored correctly - changes to
entity-factory.ts+request-data-reducer.factory.tsspacesproperty instead ofmanaged_spacesImprove efficiency when calculating user other roles - changes to
cf-user.service.tsEnsure we don't show incorrect space roles in org users list - changes to
cf-user-list-config.service.ts