Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure auth data is updated on sys info call #2595

Merged
merged 2 commits into from
Jul 2, 2018
Merged

Conversation

richard-cox
Copy link
Contributor

  • Bug - connect to endpoint, try to assign cf roles to connected user
  • Endpoint data in auth section is not kept up to date
  • Future work... remove the need for the auth endpoint section if it's a duplication of the request data endpoints section
  • Fixes Connected endpoints fail to update sessionData user #2590

- Bug - connect to endpoint, try to assign cf roles to connected user
- Endpoint data in auth section is not kept up to date
- Future work... remove the need for the auth endpoint section if it's a duplication of the request data endpoints section
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Jun 29, 2018

Codecov Report

Merging #2595 into v2-master will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##           v2-master    #2595      +/-   ##
=============================================
- Coverage      70.03%   70.02%   -0.01%     
=============================================
  Files            595      595              
  Lines          25212    25215       +3     
  Branches        5693     5694       +1     
=============================================
+ Hits           17656    17657       +1     
- Misses          7556     7558       +2

@nwmac nwmac requested a review from KlapTrap July 2, 2018 10:05
* v2-master:
  Remove subscribeOn on entity service to fix cf pages
  Weekly status
  Docs update for observeOn(asapScheduler) about ExpressionChangedAfterItHasBeenCheckedError
  RC2 Changelog
  Fix hasPage and remove debug code
  Reduce pagination observable emits and use asap scheduler for improved performance
@KlapTrap KlapTrap merged commit 9538802 into v2-master Jul 2, 2018
@nwmac nwmac deleted the fix-auth-cf-user branch June 12, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants