Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small layout changes #2593

Merged
merged 3 commits into from
Jul 4, 2018
Merged

Small layout changes #2593

merged 3 commits into from
Jul 4, 2018

Conversation

KlapTrap
Copy link
Contributor

Fix space summary page height
Removed extra space below header

@KlapTrap KlapTrap self-assigned this Jun 29, 2018
@cfdreddbot
Copy link

Hey KlapTrap!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Jun 29, 2018

Codecov Report

Merging #2593 into v2-master will decrease coverage by 0.4%.
The diff coverage is 26.19%.

@@              Coverage Diff              @@
##           v2-master    #2593      +/-   ##
=============================================
- Coverage      70.37%   69.97%   -0.41%     
=============================================
  Files            595      595              
  Lines          25202    25235      +33     
  Branches        5689     5700      +11     
=============================================
- Hits           17735    17657      -78     
- Misses          7467     7578     +111

@nwmac nwmac self-requested a review July 2, 2018 10:05
@@ -1,4 +1,4 @@
<div class="space-summary">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the width, height 100% - should we also do this on the org summary for consistency?

@nwmac nwmac added the question label Jul 3, 2018
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 07161e2 into v2-master Jul 4, 2018
@nwmac nwmac deleted the small-layout-changes branch July 4, 2018 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants