Clean entity service #2551
Merged
Clean entity service #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey KlapTrap! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2551 +/- ##
=============================================
+ Coverage 70.42% 70.43% +0.01%
=============================================
Files 594 594
Lines 25132 25136 +4
Branches 5674 5673 -1
=============================================
+ Hits 17698 17704 +6
+ Misses 7434 7432 -2 |
* v2-master: Postflight script times out if it can not connect
KlapTrap
added
comments-addressed
and removed
needs attention
richard-cox
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix issues where entities were not updating in the UI correctly.
This fix has been applied to #2518 as it fixes an issue found there.
@nwmac also hit an issue that was fixed in a similar way. I have undone the change that I did for @nwmac and applied a general fix for the issue.
It shouldn't have any issues but because it's a widely used code path, we should test well.