Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes state reset issue when creating a service instance from different modes #2515

Merged
merged 7 commits into from
Jun 26, 2018
Merged

Fixes state reset issue when creating a service instance from different modes #2515

merged 7 commits into from
Jun 26, 2018

Conversation

irfanhabib
Copy link
Contributor

@irfanhabib irfanhabib commented Jun 25, 2018 •
edited
Loading

Fixes #2519

@cfdreddbot
Copy link

Hey irfanhabib!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@irfanhabib irfanhabib self-assigned this Jun 25, 2018
@codecov
Copy link

codecov bot commented Jun 25, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (v2-master@ef9d86a). Click here to learn what that means.
The diff coverage is 61.29%.

@@             Coverage Diff              @@
##             v2-master    #2515   +/-   ##
============================================
  Coverage             ?   70.64%           
============================================
  Files                ?      590           
  Lines                ?    24836           
  Branches             ?     5614           
============================================
  Hits                 ?    17545           
  Misses               ?     7291           
  Partials             ?        0

@KlapTrap KlapTrap self-requested a review June 26, 2018 08:53
@KlapTrap
Copy link
Contributor

After following your instructions on #2473 I got the following error:

    at ServiceInstanceCardComponent._this.getSpaceURL (service-instance-card.component.ts:126)
    at Object.eval [as updateDirectives] (ServiceInstanceCardComponent.html:8)
    at Object.debugUpdateDirectives [as updateDirectives] (core.js:11914)
    at checkAndUpdateView (core.js:11307)
    at callViewAction (core.js:11548)
    at execComponentViewsAction (core.js:11490)
    at checkAndUpdateView (core.js:11313)
    at callViewAction (core.js:11548)
    at execEmbeddedViewsAction (core.js:11511)
    at checkAndUpdateView (core.js:11308) ```

@KlapTrap KlapTrap added the needs attention This PR needs attention label Jun 26, 2018
@irfanhabib irfanhabib changed the title Fix missing entity exception after a service instance is created Fixes state reset issue when creating a service instance from different modes Jun 26, 2018
@irfanhabib irfanhabib removed the needs attention This PR needs attention label Jun 26, 2018
@KlapTrap KlapTrap merged commit f6ea4a3 into v2-master Jun 26, 2018
@irfanhabib irfanhabib deleted the fix-org-refresh branch June 28, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KlapTrap KlapTrap Awaiting requested review from KlapTrap

Assignees

@irfanhabib irfanhabib

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irfanhabib @cfdreddbot @KlapTrap