Fix for app count being stuck after add in org card #2511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey nwmac! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2511 +/- ##
============================================
- Coverage 70.66% 70.56% -0.1%
============================================
Files 590 591 +1
Lines 24823 24855 +32
Branches 5611 5618 +7
============================================
- Hits 17541 17540 -1
- Misses 7282 7315 +33 |
irfanhabib
suggested changes
Jun 26, 2018
| }) | ||
| map(orgs => [].concat(...orgs.map(org => org.entity.spaces))), | ||
| switchMap((spaces: APIResource<ISpace>[]) => | ||
| combineLatest(spaces.map(space => this.store.select(selectEntity(spaceSchemaKey, space.metadata.guid)))) |
There was a problem hiding this comment.
This step isn't required. The space entities in the org entity should be up to date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2477 and also handles delete.
Ensures that when we add or delete an app, the app count show in the CF views is updated