Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure remove user confirmation modal contains correct role prefix #2508

Merged
merged 1 commit into from
Jun 23, 2018

Conversation

richard-cox
Copy link
Contributor

  • fixes 2502
  • permission name can now be null at org/space levels
  • ensure we treat role pill label and confirmation label the same (handling nulls)

- permission name can now be null at org/space levels
- ensure we treat role pill label and confirmation label the same (handling nulls)
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Jun 22, 2018

Codecov Report

Merging #2508 into v2-master will decrease coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##           v2-master    #2508      +/-   ##
=============================================
- Coverage      70.65%   70.64%   -0.01%     
=============================================
  Files            590      590              
  Lines          24822    24824       +2     
  Branches        5611     5611              
=============================================
+ Hits           17537    17538       +1     
- Misses          7285     7286       +1

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 42c13a3 into v2-master Jun 23, 2018
@nwmac nwmac deleted the fix-user-confirm branch June 23, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants