Fix failure to update commit info on redeploy #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Jun 21, 2018
richard-cox
commented
- Fixes Redeploy does not update commit id of deployment #2419
- Blocked on Fixed exception after unmapping routes #2488
- Not reproducible on quick systems (local pcf)
- Ensure we also update env vars when we leave the deploy stepper
- Catches edge cases where the standard call to env vars happened to early to have updated info
- Also catch case where we weren't calling onLeave when leaving stepper via close/cancel
- Not reproducable on quick systems (local pcf) - Ensure we also update env vars when we leave the deploy stepper - Catches edge cases where the standard call to env vars happened to early to have updated info - Also catch case where we weren't calling onLeave when leaving stepper via close/cancel
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2492 +/- ##
=============================================
- Coverage 70.72% 70.72% -0.01%
=============================================
Files 590 590
Lines 24835 24837 +2
Branches 5606 5607 +1
=============================================
Hits 17565 17565
- Misses 7270 7272 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.