Fix layout on summary pages #2482
Conversation
|
Hey KlapTrap! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2482 +/- ##
==========================================
Coverage 70.74% 70.74%
==========================================
Files 589 589
Lines 24802 24802
Branches 5595 5595
==========================================
Hits 17546 17546
Misses 7256 7256 |
| @@ -1,5 +1,5 @@ | |||
| .summary { | |||
| display: flex; | |||
| height: 100%; | |||
| min-height: 100%; | |||
There was a problem hiding this comment.
With the current layout - the last card - the recent apps is supposed to size to the remaining space - with this change, this is no longer the case.
There was a problem hiding this comment.
What are we trying to achieve by having the recent apps shrink to fit the remaining size rather than being it's natural height?
There was a problem hiding this comment.
The intent was that the remaining space would be used for the apps list - so the more height there was, the more of the list that would be visible, rather than fixing some arbitrary height.
See: #2483 for a fix which I think keeps this behaviour but avoid the overlap issue.
On screens with smaller height, the cf summary pages collapses and cards overlap.