Support OAuth login to console - V2 #2479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto shared-endpoints
…nto shared-endpoints
# Conflicts: # src/frontend/app/shared/components/list/list-types/cf-endpoints/cf-endpoint-card/endpoint-card.component.spec.ts # src/frontend/app/store/reducers/current-user-roles-reducer/current-user-role-session.reducer.ts
…org-user-permissions Disable removal of `org user` role if user has others
…ed-endpoints Allow metrics endpoint token to be shared
…unit-tests Fix unit tests
|
Hey andrewghobrial! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2479 +/- ##
=============================================
- Coverage 70.74% 70.71% -0.03%
=============================================
Files 589 589
Lines 24802 24817 +15
Branches 5595 5599 +4
=============================================
+ Hits 17546 17550 +4
- Misses 7256 7267 +11 |
nwmac
approved these changes
Jun 21, 2018
nwmac
approved these changes
Jun 21, 2018
Merged
|
@nwmac the login hook runs locally and when deployed as all in one container too. i added it to the cloudfoundry plugin not the cf-hosting plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is v2 version of: #2139