Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the connected user roles section of store on roles change #2435

Merged
merged 2 commits into from
Jun 20, 2018
Merged

Update the connected user roles section of store on roles change #2435

merged 2 commits into from
Jun 20, 2018

Conversation

richard-cox
Copy link
Contributor

@richard-cox
Update the connected user roles section of store on roles change
f390ab0 
- includes renaming of role change actions from 'permissions' to 'roles'
@richard-cox richard-cox self-assigned this Jun 19, 2018
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Jun 19, 2018 •
edited
Loading

Codecov Report

Merging #2435 into v2-master will decrease coverage by 0.14%.
The diff coverage is 34%.

@@              Coverage Diff              @@
##           v2-master    #2435      +/-   ##
=============================================
- Coverage      70.96%   70.81%   -0.15%     
=============================================
  Files            588      589       +1     
  Lines          24703    24760      +57     
  Branches        5559     5578      +19     
=============================================
+ Hits           17530    17534       +4     
- Misses          7173     7226      +53

nwmac
nwmac approved these changes Jun 20, 2018
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox
Copy link
Contributor Author

Merging. Tests failing in master

@richard-cox richard-cox merged commit 7c93550 into v2-master Jun 20, 2018
@irfanhabib irfanhabib deleted the update-user-roles branch June 28, 2018 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-cox @cfdreddbot @nwmac