Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination of space level routes and service instance tables #2429

Merged
merged 1 commit into from
Jun 20, 2018

Conversation

richard-cox
Copy link
Contributor

- Actions were set to flattenPagination
- Ensure consistent page size between the two tables as well as other si tables
(5 for table only, otherwise 9)
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Jun 19, 2018

Codecov Report

Merging #2429 into v2-master will decrease coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##           v2-master    #2429      +/-   ##
=============================================
- Coverage      71.03%   71.03%   -0.01%     
=============================================
  Files            585      585              
  Lines          24536    24529       -7     
  Branches        5509     5505       -4     
=============================================
- Hits           17429    17424       -5     
+ Misses          7107     7105       -2

@irfanhabib
Copy link
Contributor

LGTM

@irfanhabib irfanhabib merged commit 2122ffa into v2-master Jun 20, 2018
@irfanhabib irfanhabib deleted the fix-space-routes-and-si-tables branch June 20, 2018 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants