Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link to space for service instances #2384

Merged
merged 5 commits into from
Jun 18, 2018
Merged

Add link to space for service instances #2384

merged 5 commits into from
Jun 18, 2018

Conversation

irfanhabib
Copy link
Contributor

@irfanhabib irfanhabib commented Jun 14, 2018 •
edited
Loading

@cfdreddbot
Copy link

Hey irfanhabib!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@irfanhabib irfanhabib self-assigned this Jun 14, 2018
@codecov
Copy link

codecov bot commented Jun 14, 2018 •
edited
Loading

Codecov Report

Merging #2384 into v2-master will increase coverage by 0.03%.
The diff coverage is 93.75%.

@@              Coverage Diff              @@
##           v2-master    #2384      +/-   ##
=============================================
+ Coverage      71.05%   71.08%   +0.03%     
=============================================
  Files            583      584       +1     
  Lines          24451    24487      +36     
  Branches        5483     5496      +13     
=============================================
+ Hits           17373    17406      +33     
- Misses          7078     7081       +3

richard-cox
richard-cox suggested changes Jun 18, 2018
View reviewed changes
Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue, otherwise LGTM.
Following error is shown in space service instance tab

ERROR TypeError: Cannot read property 'entity' of undefined
    at Object.eval [as updateRenderer] (TableCellSpaceNameComponent.html:1)

@richard-cox richard-cox added needs attention This PR needs attention and removed in review labels Jun 18, 2018
@irfanhabib
Copy link
Contributor Author

@richard-cox Fixed entity issue in Cf Spaces service instances list

@irfanhabib irfanhabib added comments-addressed and removed needs attention This PR needs attention labels Jun 18, 2018
@richard-cox richard-cox merged commit 41e0bea into v2-master Jun 18, 2018
@richard-cox richard-cox deleted the show-space branch June 18, 2018 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

Assignees

@irfanhabib irfanhabib

Labels
in review ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irfanhabib @cfdreddbot @richard-cox