Validate host/path pattern in Create Route form #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey irfanhabib! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
nwmac
suggested changes
Jun 18, 2018
| @@ -33,7 +33,8 @@ import { Domain } from '../../../../store/types/domain.types'; | |||
| import { Route, RouteMode } from '../../../../store/types/route.types'; | |||
| import { ApplicationService } from '../../application.service'; | |||
|
|
|||
|
|
|||
| const hostPattern = '(([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]*[a-zA-Z0-9])\.)*([A-Za-z0-9]|[A-Za-z0-9][A-Za-z0-9\-]*[A-Za-z0-9])'; | |||
| const pathPattern = `^((\/)${hostPattern}?(\/)*)*$`; | |||
There was a problem hiding this comment.
I think the path allows more chars than the host. See: https://tools.ietf.org/html/rfc3986#section-3.3 and https://tools.ietf.org/html/rfc3986#appendix-A
| @@ -33,7 +33,8 @@ import { Domain } from '../../../../store/types/domain.types'; | |||
| import { Route, RouteMode } from '../../../../store/types/route.types'; | |||
| import { ApplicationService } from '../../application.service'; | |||
|
|
|||
|
|
|||
| const hostPattern = '(([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]*[a-zA-Z0-9])\.)*([A-Za-z0-9]|[A-Za-z0-9][A-Za-z0-9\-]*[A-Za-z0-9])'; | |||
There was a problem hiding this comment.
This is not correct - it allows lots of invalid characters - e.g. /, % etc - see: https://en.wikipedia.org/wiki/Hostname for a simple explanation of what is allowed.
added 2 commits
June 18, 2018 15:08
Codecov Report
@@ Coverage Diff @@
## v2-master #2383 +/- ##
=============================================
+ Coverage 71.04% 71.05% +<.01%
=============================================
Files 583 583
Lines 24452 24454 +2
Branches 5483 5483
=============================================
+ Hits 17373 17375 +2
Misses 7079 7079 |
irfanhabib
added
comments-addressed
and removed
needs attention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.