Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable unbind operation in space-services #2378

Merged
merged 4 commits into from
Jun 18, 2018
Merged

Conversation

irfanhabib
Copy link
Contributor

@irfanhabib irfanhabib commented Jun 13, 2018

  1. Refactors out cancel URL code from stepper component to service.
  2. Add Edit Service Instance action to service-binding card in App Services.
  3. Fixed Can't unbind apps from a service #2359

@cfdreddbot
Copy link

Hey irfanhabib!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@irfanhabib irfanhabib self-assigned this Jun 13, 2018
@codecov
Copy link

codecov bot commented Jun 13, 2018

Codecov Report

Merging #2378 into v2-master will decrease coverage by 0.01%.
The diff coverage is 58.33%.

@@              Coverage Diff              @@
##           v2-master    #2378      +/-   ##
=============================================
- Coverage      71.04%   71.03%   -0.02%     
=============================================
  Files            583      583              
  Lines          24452    24459       +7     
  Branches        5483     5485       +2     
=============================================
+ Hits           17373    17374       +1     
- Misses          7079     7085       +6

@richard-cox richard-cox added the conflicts Merge conflicts on PR label Jun 15, 2018
@irfanhabib irfanhabib added comments-addressed and removed conflicts Merge conflicts on PR labels Jun 18, 2018
@richard-cox richard-cox merged commit bf6d5b6 into v2-master Jun 18, 2018
@richard-cox richard-cox deleted the add-unbind-operation branch June 18, 2018 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants