Add global deleting overlay for entity summary pages #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey KlapTrap! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2373 +/- ##
=============================================
- Coverage 71.11% 71.06% -0.05%
=============================================
Files 582 583 +1
Lines 24398 24478 +80
Branches 5467 5486 +19
=============================================
+ Hits 17351 17396 +45
- Misses 7047 7082 +35 |
richard-cox
added
needs attention
* v2-master: (33 commits) Fix console image name Fix not detecting admin user is admin scope is not stratos.admin Update status_updates.md Update passthrough.go Update roadmap Weekly status updates Remove auto select of service and improve service select Add delete space confirmation @ space level Removed console.log, fixed console.log linting, show warning for space pills as well Ignore cookie domain for now Fix file path for output Trigger on tag Update release pipeline Fix bad error formatting Tidy up pagination key creation - Ensure there's one common base way to create pagination key - Tidy up how that base is used WRT to entity relation pagination key - Ensure all lists that run against all endpoints have a common pagination key Fix space selection when user returns to CFOrgSpace selector Fix issue where circular reference failed to denormalize an app's space - Connect to scf, no other endpoint (bug is app specific) - to reproduce... - Fresh load on CF page - Click Services nav item - Click Applications nav item - apps in third column did not denormalize their space entity, causing undefined error - Caused by app's space's service instances containing app bindings Fix env var modal exception after a service binding has been created Unit test fixes Tidy up the bind app step ...
KlapTrap
removed
conflicts
richard-cox
approved these changes
Jun 19, 2018
There was a problem hiding this comment.
LGTM. Hard to test the delete app, delete space works fine. Have created #2424 to cover adding the org summary delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See application delete from the application summary.