Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various application deploy bugs #2372

Merged
merged 3 commits into from
Jun 19, 2018
Merged

Fix various application deploy bugs #2372

merged 3 commits into from
Jun 19, 2018

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Jun 13, 2018

This PR fixes a few app deploy bugs. It:

  • Removes subtype and changes the selection to 4 types - GitHub, Git URL, App File, App Folder to simplify the UI
  • Sets GitHub back to the default choice
  • Creates new form field models for the Git URL case, so it does not share these with GitHub
  • Fixes a bug where the close button did not get enabled when deploying form file or folder

@cfdreddbot
Copy link

Hey nwmac!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@nwmac nwmac self-assigned this Jun 13, 2018
@nwmac nwmac added the V2 label Jun 13, 2018
@codecov
Copy link

codecov bot commented Jun 13, 2018 •
edited
Loading

Codecov Report

Merging #2372 into v2-master will increase coverage by <.01%.
The diff coverage is 67.01%.

@@              Coverage Diff              @@
##           v2-master    #2372      +/-   ##
=============================================
+ Coverage      71.04%   71.04%   +<.01%     
=============================================
  Files            581      585       +4     
  Lines          24310    24509     +199     
  Branches        5450     5504      +54     
=============================================
+ Hits           17270    17412     +142     
- Misses          7040     7097      +57

@irfanhabib irfanhabib self-requested a review June 15, 2018 08:56
@irfanhabib irfanhabib removed their request for review June 15, 2018 14:05
@richard-cox richard-cox self-requested a review June 18, 2018 12:28
richard-cox
richard-cox suggested changes Jun 18, 2018
View reviewed changes
Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the deployment type is not sent to the backend. It's missing from the STRATOS_PROJECT json and we won't shop the deployment info detail or github tab.
Once in would like to confirm the stepper looks good when it's a redeploy.

@richard-cox richard-cox added needs attention This PR needs attention and removed in review labels Jun 18, 2018
@nwmac nwmac added comments-addressed and removed needs attention This PR needs attention labels Jun 19, 2018
@richard-cox richard-cox merged commit 9270744 into v2-master Jun 19, 2018
@richard-cox richard-cox deleted the fix-deploy-issues branch June 19, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

Assignees

@nwmac nwmac

Labels
in review ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nwmac @cfdreddbot @richard-cox @irfanhabib