Allow metrics endpoint token to be shared #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey nwmac! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2283 +/- ##
=============================================
- Coverage 71.05% 71.02% -0.03%
=============================================
Files 585 585
Lines 24537 24548 +11
Branches 5510 5512 +2
=============================================
+ Hits 17435 17436 +1
- Misses 7102 7112 +10 |
# Conflicts: # src/frontend/app/shared/components/list/list-types/cf-endpoints/cf-endpoint-card/endpoint-card.component.spec.ts # src/frontend/app/store/reducers/current-user-roles-reducer/current-user-role-session.reducer.ts
|
LGTM. Works only for metrics shared endpoints, for CF endpoints I ran into permission issues. |
irfanhabib
approved these changes
Jun 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-admin users most likely will not have permissions to connect to the prometheus server.
This PR allows admins to share their tokens with all users - the backend metrics can then use the admin token to get the metrics for an application that the requesting user has permission to access.
This allows non-admin users to see application metrics for their applications. They can't see any other metrics.