Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint confirmation modals #2258

Merged
merged 5 commits into from
Jun 7, 2018
Merged

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Jun 4, 2018

Add confirmation modals for unregistering and disconnecting endpoints.

Update e2e tests.

@cfdreddbot
Copy link

Hey nwmac!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@nwmac nwmac self-assigned this Jun 4, 2018
@codecov
Copy link

codecov bot commented Jun 4, 2018

Codecov Report

Merging #2258 into v2-master will decrease coverage by <.01%.
The diff coverage is 26.66%.

@@              Coverage Diff              @@
##           v2-master    #2258      +/-   ##
=============================================
- Coverage      65.55%   65.54%   -0.01%     
=============================================
  Files            571      571              
  Lines          16781    16788       +7     
  Branches        2149     2149              
=============================================
+ Hits           11000    11004       +4     
- Misses          5781     5784       +3

@richard-cox richard-cox added the conflicts Merge conflicts on PR label Jun 5, 2018
@nwmac nwmac removed the conflicts Merge conflicts on PR label Jun 5, 2018
…ation-modals

# Conflicts:
#	src/frontend/app/shared/components/list/list-types/endpoint/endpoints-list-config.service.ts
@irfanhabib irfanhabib merged commit 209b3c0 into v2-master Jun 7, 2018
@irfanhabib irfanhabib deleted the endpoint-confirmation-modals branch June 7, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants