Fix App SSH (Broken when auth and token endpoints are different) #2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey nwmac! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
nwmac
changed the title
Codecov Report
@@ Coverage Diff @@
## v2-master #2250 +/- ##
=============================================
- Coverage 71.78% 71.46% -0.33%
=============================================
Files 565 576 +11
Lines 23192 24292 +1100
Branches 5205 5443 +238
=============================================
+ Hits 16649 17360 +711
- Misses 6543 6932 +389 |
|
LGTM |
|
Thanks for adding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are incorrectly using the Auth endpoint and not the token endpoint - for many providers these are the same, but if they are not, SSH is broken.
Also improved the logging