Fix compression issue #2248
Merged
Fix compression issue #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey nwmac! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
8 tasks
Codecov Report
@@ Coverage Diff @@
## v2-master #2248 +/- ##
==========================================
Coverage 71.78% 71.78%
==========================================
Files 565 565
Lines 23192 23192
Branches 5205 5205
==========================================
Hits 16649 16649
Misses 6543 6543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the compression issue that does not require compression to be tuned off.
Long and short is the issue boiled down to the fact that when the back-end proxies API requests, it forwards (most of) the headers as well.
The golang http library (see: https://golang.org/src/net/http/transport.go, line 1973), assumes that if the Accept-Encoding header is set by the client, then it will handle uncompressing the response if it is compressed.
Since the browser typically sends us this header, we forward it on and in the case of backends using compression, we get back a compressed response which the go library assumes that we will uncompress, which we do not.
The fix is simply to not forward the Accepts-Encoding header and to let the go library do its thing - it will add in gzip and uncompress the response for us if necessary