Fix application issue on reload when served by backend #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey nwmac! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
nwmac
changed the title
Codecov Report
@@ Coverage Diff @@
## v2-master #2238 +/- ##
==========================================
Coverage 71.78% 71.78%
==========================================
Files 565 565
Lines 23192 23192
Branches 5205 5205
==========================================
Hits 16649 16649
Misses 6543 6543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the backend is serving the UI - e.g. in the case of cf push, reloading was broken in the app - with Angular it uses "proper" URLs rather than the # - so the backend does not know about these routes and returns a 404 - to reproduce, cf push Stratos, navigate to part of the UI and hit the browser refresh button.
This PR fixes this - when the backend is serving the UI, it now adds an error handler and if the error is 404 and the request was not a backend API request, the application's index.html will be returned, allowing it to route correctly.