-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update permissions when when entities are updated #2221
Conversation
…necting or removing them
* v2-master: (55 commits) Add code coverage config file Tweak to cover radio button in single select columns (map existing route table) Remove todo from firehose permission - tested for admin/non admin - admin read-only needs to be applied later on - doppler.firehose scope wasn't required to show the firehose Add user info to the response when connecting an endpoint Fix tests Fix typing issue, highlighted by unit tests Ensure we handle cases where the permissions haven't been fetched yet Revert "Add `has space role in any space in any cf org`" Real fix Add `has space role in any space in any cf org` Three changes - Ensure there's no dups in org spaceGuids list - Fetch list of spaceGuids from org and not space object - Wire in new all spaces Fix selection following merge - Fix issue in master where select column/multi actions not showing - Fix manage users selection columns Fix return to select users step (missing user rows) - The ngIf on selected users which determines if the step is visible flipped - This caused the table to disconnect, which was never connected again - Not sure how the step was even still visible Fix redirect for states without query params Re-add selected users list to modify roles step, fixed title when start with multi users - This was brought up in demo - Needed in some cases for warm fuzzies (user has preselected users list, either single or multiple) - Only case where we might not show it is when the select users step is shown, however for consistency felt it should be the same for all Fix stepper blocked indicator (failed to populate cf/users when nav direct and single user) Update app-service-binding-card.component.spec.ts Ensure query params are retained through auth guard/login redirect Increase jasmine timeout to 10 seconds Do proper check when checking all spaces ...
Hey KlapTrap! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2221 +/- ##
============================================
+ Coverage 65.51% 71.71% +6.2%
============================================
Files 571 572 +1
Lines 16782 23588 +6806
Branches 2151 5312 +3161
============================================
+ Hits 10994 16916 +5922
- Misses 5788 6672 +884 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might jump the gun with the review. Couple of comments and one issue
- register endpoint and connect as admin and the 'admin' permission isn't updated
if (!state.cf[endpointGuid].organizations[guid]) { | ||
return state; | ||
} | ||
// const spaceIds = state.cf[endpointGuid].organizations[guid].spaceIds; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment
...state.cf[endpointGuid].organizations, | ||
[orgId]: { | ||
...state.cf[endpointGuid].organizations[orgId], | ||
spaceIds: state.cf[endpointGuid].organizations[orgId].spaceGuids.filter(id => id !== spaceGuid) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed comment from review... spaceIds
--> spaceGuids
* v2-master: (136 commits) Fix merge, height of recent updated service instances + gate-check target Fixes - app breadcrumb for market place --> app (could be fixed in master) - quotes in cli pages (show) and `f` -> `cf` in one place - margin between cancel and next in stepper - app chip list margins and alignment - remove a debug line Removed uneeded files Resolve merge conflict Fixs Updates for week ending 1st June Fix for permissions issue with node Three fixes - Bind app to existing service with binding params - Updated default sort order to always show latest first - Update name of sort type of app service instance table (creation date --> bind date) Fix App SSH Addressed feedback Fix compression issue Fixed unit tests Remove AIO base image because of similarity to BK Build Changing node version the LTE Update to latest LTS for angular 6 migration Fixed merge issues Bumped node version again Updated node version on travis.yml file Updated node version Fix e2e target ...
CF Endpoint:
Org:
Space:
We don't fetch permissions on creation as the current user won't have any permissions at that point.