Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for backend custom plugins #2217

Merged
merged 10 commits into from
May 25, 2018
Merged

Add support for backend custom plugins #2217

merged 10 commits into from
May 25, 2018

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented May 23, 2018 •
edited
Loading

This PR:

  • Moves the customisation tasks into a separate file
  • Adds support for custom backend plugins
  • Adds a build target for backend dev
  • Adds a default plugin.conf.js for backend dev

@nwmac nwmac self-assigned this May 23, 2018
@cfdreddbot
Copy link

Hey nwmac!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented May 24, 2018 •
edited
Loading

Codecov Report

Merging #2217 into v2-master will increase coverage by 0.02%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           v2-master    #2217      +/-   ##
=============================================
+ Coverage       72.3%   72.32%   +0.02%     
=============================================
  Files            559      559              
  Lines          22796    22796              
  Branches        5121     5121              
=============================================
+ Hits           16482    16487       +5     
+ Misses          6314     6309       -5

irfanhabib
irfanhabib suggested changes May 24, 2018
View reviewed changes
Copy link
Contributor

@irfanhabib irfanhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we should create a backup of the existing proxy.conf.js in case there is already one

build/bk-build.js
if (!fs.existsSync(proxyConf)) {
fs.copySync(localProxyConf, proxyConf);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is already a proxy.conf.js we could make a backup by renaming it to proxy.conf.js.bk and write out the new one. This would preserve the file in case someone wants to go back to it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't overwrite one if there is already one there - this is just there for the first time, of-out-box case.

@irfanhabib irfanhabib added needs attention This PR needs attention and removed in review labels May 24, 2018
@irfanhabib irfanhabib merged commit 9ce043e into cloudfoundry:v2-master May 25, 2018
@irfanhabib irfanhabib deleted the extenstions branch May 25, 2018 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irfanhabib irfanhabib irfanhabib requested changes

Assignees

@nwmac nwmac

Labels
needs attention This PR needs attention ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nwmac @cfdreddbot @irfanhabib