-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply user permissions to CF pages #2198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
May 18, 2018
•
edited
Loading
edited
- This is an iterative step towards a final pass of the CF pages
- added permission config for some of the major actions taken in them
- wired in most permissions from the cf roles table
- Includes some general permissions bug fixes
- Also includes changes to the list component to wire permissions in ..
- global, multi + row list actions can now be wired into permissions
- if there are no allowed multi actions the select column in table view will be removed
- if there are no allowed row actions the menu is removed.
…enabled - global, multi + row list actions can now be wired into permissions - zero visible multi actions will result in the select column being removed - zero visible row actions will result in the menu being replaced with '-'
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
* v2-master: (31 commits) 18 May updates Ensure that the customize task is run Fixed tests Small improvements - always use admin for clearing, register and unregister of endpoints Update package.json Tidy up e2e helpers. One more attempt to run e2e tests based on branch name Don't log Client Secret Tidy up the backend start-up logging Update .travis.yml Update .travis.yml Fix for checking branch of the pull request Update .travis.yml Update .travis.yml Update .travis.yml Update .travis.yml Run e2e tests for branches that contain the string 'e2e' E2E tests for CF Endpoints view Ignore custom sass folder Link custom sass folder too ...
* v2-master: (23 commits) Add back in newline at end of file Fix 2 unit test failures Remove blank line Remove debug line Check for any skipped unit tests when running in CI Remove fdescribe Detach fix revert deleted files Remove incorrectly committed files Changes in response to feedback Update imports Migrate to helper to a data service Fix guid typo fix lint issue Fix unit tests Drop deprecated API Update services.service.mock.ts Remove ngOnInit Update service-instance-card.component.html Fix unit tests ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.