Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply user permissions to CF pages #2198

Merged
merged 17 commits into from
May 22, 2018
Merged

Apply user permissions to CF pages #2198

merged 17 commits into from
May 22, 2018

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented May 18, 2018

  • This is an iterative step towards a final pass of the CF pages
    • added permission config for some of the major actions taken in them
    • wired in most permissions from the cf roles table
  • Includes some general permissions bug fixes
  • Also includes changes to the list component to wire permissions in ..
    • global, multi + row list actions can now be wired into permissions
    • if there are no allowed multi actions the select column in table view will be removed
    • if there are no allowed row actions the menu is removed.

@richard-cox richard-cox self-assigned this May 18, 2018
@richard-cox richard-cox requested a review from KlapTrap May 18, 2018 15:49
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

KlapTrap and others added 3 commits May 21, 2018 13:29
* v2-master: (31 commits)
  18 May updates
  Ensure that the customize task is run
  Fixed tests
  Small improvements - always use admin for clearing, register and unregister of endpoints
  Update package.json
  Tidy up e2e helpers.
  One more attempt to run e2e tests based on branch name
  Don't log Client Secret
  Tidy up the backend start-up logging
  Update .travis.yml
  Update .travis.yml
  Fix for checking branch of the pull request
  Update .travis.yml
  Update .travis.yml
  Update .travis.yml
  Update .travis.yml
  Run e2e tests for branches that contain the string 'e2e'
  E2E tests for CF Endpoints view
  Ignore custom sass folder
  Link custom sass folder too
  ...
* v2-master: (23 commits)
  Add back in newline at end of file
  Fix 2 unit test failures
  Remove blank line
  Remove debug line
  Check for any skipped unit tests when running in CI
  Remove fdescribe
  Detach fix
  revert deleted files
  Remove incorrectly committed files
  Changes in response to feedback
  Update imports
  Migrate to helper to a data service
  Fix guid typo
  fix lint issue
  Fix unit tests
  Drop deprecated API
  Update services.service.mock.ts
  Remove ngOnInit
  Update service-instance-card.component.html
  Fix unit tests
  ...
@KlapTrap KlapTrap merged commit f6e9c6b into v2-master May 22, 2018
@nwmac nwmac deleted the apply-user-permissions branch September 13, 2018 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants