User permissions #2147
Merged
User permissions #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* v2-master: (77 commits) Fixed small typos Removed console.log, unsub before reassigning sub Fix merge issues Weekly status update Do not show menu items when non admin with no endpoints Validate service and app binding params are JSON Fix chip list indentation Lint fox Tidy up deletion screen Fix instance delete Rename selectors CC fixes Fixed tests Delete unused method Fix lint Stop event bubbling Get most recent apps Fixed some tests Addressed review comments Recursive delete application ...
|
Hey KlapTrap! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
* v2-master: (161 commits) Small improvements for back end dev Ignores PRs for e2e tests FIx formatting Use no-sandbox as generally recommended Don't run e2e tests on PRs Address PR feedback Markup codeclimate fixes.. Tweak secrets.yaml + missing message Four fixes/tweaks - Tweak select folder/file button padding to ensure we don't wrap - Tweak host flex to ensure git input fields don't wibble when switching type - Fixed bug where deploy step close button would not become enabled on errors - Fixed issue where new github 'source config' step was never shown Add first to one time obs sub Fix line length lint error Move dev notes from wiki to docs/ Update current password required based to reflect if it is required This week's status updates First set of fixes to address PR feedback Fix stepper issue with redirect not working Fix code climate issue Fix some code climate issues Fix merge issue Update snackbar.po.ts ...
richard-cox
reviewed
May 16, 2018
| @@ -1,12 +1,15 @@ | |||
| <app-page-header [endpointIds$]="cfIds$"> | |||
| {{canCreateApplication$ | async}} | |||
| ) { | ||
| const dataSource: ListDataSource<APIResource> = appListConfig.getDataSource(); | ||
| this.cfIds$ = cloudFoundryService.cFEndpoints$.pipe( | ||
| map(endpoints => endpoints.map(endpoint => endpoint.guid)) | ||
| tap(endpoints => endpoints.forEach(endpoint => { |
| })); | ||
|
|
||
| getRequests(endpoints: EndpointModel[]) { | ||
| return [].concat(...endpoints.map(endpoint => { |
There was a problem hiding this comment.
check this doesn't run for admins
| return menuItem; | ||
| }); | ||
| this.showMenu$ = combineLatest(actionMenu.map(menuItem => menuItem.can)).pipe( | ||
| tap(console.log), |
| return actions; | ||
| }) | ||
| ); | ||
| })); |
| } | ||
|
|
||
| if (type === PermissionTypes.ENDPOINT) { | ||
| return this.store.select(getCurrentUserCFGlobalState(permission)); |
| @@ -0,0 +1,101 @@ | |||
| import { ActionState } from '../reducers/api-request-reducer/types'; | |||
richard-cox
approved these changes
May 17, 2018
There was a problem hiding this comment.
Once tests pass this LGTM. Do you want this in before or after user management (there's some minor conflicts)?
I've created #2181 for syncing role changes to permission state (thought this was best as a separate PR to #2118).
We've also got existing #2175 to cover applying these permissions everywhere and #1741 to walk through console as non-cf admin + associated issues.
* v2-master: (22 commits) Remove passthrough from delete service instance Fix service instance bound app links - Previously cfGuid was `undefined` - Breadcrumbs fixed, previously only one of three was correct - Remove errant <p> from meta card titles, this matches org and space tiles Fix unit tests Fix update of table Removed fdescribe + comment Final tweaks Fix merge conflict Changes in response to feedback Merge fix Fix lint Action menu Fix unit tests CC refactor tweaks Flesh out card view Add text search Services Wall with filters Services wall skeleton Bug fix for unit test,. Tidy up. Fix lint issues ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base framework to get user roles and work out their permissions.
Note: This hasn't been applied to all areas of the app, we will do this in another PR.