Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CF Push: Bump up memory further #2135

Merged
merged 2 commits into from
May 10, 2018
Merged

CF Push: Bump up memory further #2135

merged 2 commits into from
May 10, 2018

Conversation

irfanhabib
Copy link
Contributor

No description provided.

@cfdreddbot
Copy link

Hey irfanhabib!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 4cfbe41 into v2-master May 10, 2018
@nwmac nwmac deleted the update-manifest branch May 10, 2018 10:21
@rogeruiz
Copy link
Contributor

@irfanhabib Why is the memory so high for this? In order to deploy Stratos HA we need about 9GB because we're deploying 3 instances at 1.5GB while running the previous 3x1.5GB instances. Is there a particular reason the memory is so high? When looking at the output of cf app stratos I'm seeing it not using much memory at all when idle 8.8M of 1.5G but then when a single user is on the app, I see it spike to 31.1M of 1.5G.

@irfanhabib
Copy link
Contributor Author

irfanhabib commented Jul 16, 2018

@rogeruiz Unfortunately, CF currently doesn't support providing separate memory limits for deploying an app and when its deployed. We require significant amounts of memory when we're building the app (Since building an angular2 app is a memory intensive process). While we don't require much while its running. The app is built when you do a cf push.
The memory limit can be scaled down after the app has been pushed, using the cf CLI.

@rogeruiz
Copy link
Contributor

Ah perfect. That's what I arrived to with some sleuthing in CF Slack. Thanks @irfanhabib. Would it make more sense to build the app before deploying it? Maybe I can help with that. Also, is there a way to load test what memory limits it requires when it's running besides having a few dozen people clicking around the interface?

@irfanhabib
Copy link
Contributor Author

@rogeruiz We've gone back and forth on this, but generally we believe its a good idea to have the entire app built when we perform a cf push. Partially building the app before a push, is against the principle of cf push (where the application being pushed should be built using a buildpack).

Any thought @nwmac?

@rogeruiz
Copy link
Contributor

rogeruiz commented Jul 16, 2018

@irfanhabib, what if we leverage cf-dockerized-buildpacks? https://github.com/18F/cf-dockerized-buildpack

Or at bare minimum I could write up some docs on what the size should be after the deployment?

RE:

Also, is there a way to load test what memory limits it requires when it's running besides having a few dozen people clicking around the interface?

@irfanhabib
Copy link
Contributor Author

@rogeruiz I agree we should document what the min. size should be after a deployment.

Also, is there a way to load test what memory limits it requires when it's running besides having a few dozen people clicking around the interface?

We don't have any mechanism yet to load test the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants