-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CF Push: Bump up memory further #2135
Conversation
Hey irfanhabib! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@irfanhabib Why is the memory so high for this? In order to deploy Stratos HA we need about 9GB because we're deploying 3 instances at 1.5GB while running the previous 3x1.5GB instances. Is there a particular reason the memory is so high? When looking at the output of |
@rogeruiz Unfortunately, CF currently doesn't support providing separate memory limits for deploying an app and when its deployed. We require significant amounts of memory when we're building the app (Since building an angular2 app is a memory intensive process). While we don't require much while its running. The app is built when you do a |
Ah perfect. That's what I arrived to with some sleuthing in CF Slack. Thanks @irfanhabib. Would it make more sense to build the app before deploying it? Maybe I can help with that. Also, is there a way to load test what memory limits it requires when it's running besides having a few dozen people clicking around the interface? |
@rogeruiz We've gone back and forth on this, but generally we believe its a good idea to have the entire app built when we perform a Any thought @nwmac? |
@irfanhabib, what if we leverage cf-dockerized-buildpacks? https://github.com/18F/cf-dockerized-buildpack Or at bare minimum I could write up some docs on what the size should be after the deployment? RE:
|
@rogeruiz I agree we should document what the min. size should be after a deployment.
We don't have any mechanism yet to load test the app. |
No description provided.