Customizations #2133
Merged
Customizations #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey nwmac! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
…ratos into customizations
|
Looked through the code and there's no code smells. Tested using the custom src theme and all works. Going forward will the custom module basically replace the old frontend plugins concept? |
richard-cox
approved these changes
May 15, 2018
|
CustomModule is a simple hook that lets you incorporate custom modules etc, so it should replace the old plugins mechanism for the front end. We still need to define extension points (e.g. nav, tabs) to allow extensions to add themselves into the UI at the right places. |
* v2-master: (53 commits) Fixed tests Remove passthrough from delete service instance Backend unit test fix Fix backend unit test Fix service instance bound app links - Previously cfGuid was `undefined` - Breadcrumbs fixed, previously only one of three was correct - Remove errant <p> from meta card titles, this matches org and space tiles Removed more unused code Fix unit tests Use correct stratos admin scope when finding if current user is a admin Fixed issues found on initial review Fix update of table Removing fdescribe Fixing tests Removed fdescribe + comment Final tweaks Removed test code Small improvements for back end dev Fixed linting Added unit tests Fix merge conflict Changes in response to feedback ...
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.