Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return better error information from API passthroughs #2085

Merged
merged 5 commits into from
May 2, 2018
Merged

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Apr 25, 2018

When proxying, the wrapper responses will now contain better error information.

@nwmac nwmac self-assigned this Apr 25, 2018
@cfdreddbot
Copy link

Hey nwmac!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tweaked the generic catch though. @nwmac if it looks good to you then it's good to merge

@nwmac nwmac merged commit b1cc5fb into v2-master May 2, 2018
@nwmac nwmac deleted the proxy-errors branch May 2, 2018 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants