Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new scf-config-values format #1949

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Support new scf-config-values format #1949

merged 1 commit into from
Apr 11, 2018

Conversation

irfanhabib
Copy link
Contributor

No description provided.

@cfdreddbot
Copy link

Hey irfanhabib!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@irfanhabib
Copy link
Contributor Author

irfanhabib commented Apr 11, 2018 •
edited
Loading

To test with the new config values format, use the following:

env:
    DOMAIN: cf-dev.io
kube:
    external_ips:
    - 192.168.77.77
    - 192.168.77.78
    - 192.168.77.79
    storage_class:
        persistent: "persistent"
        shared: "shared"
    registry:
       hostname: "staging.registry.howdoi.website"
       username: "legituser"
       password: ""
    organization: "splatform"
    auth: rbac
secrets:
    CLUSTER_ADMIN_PASSWORD: changeme
    UAA_ADMIN_CLIENT_SECRET: uaa-admin-client-secret

Save it to new-scf-config.yaml and run helm with:

$ cd deploy/kubernetes
$ helm install console/ -f new-scf-config.yaml --dry-run --debug | grep -A18 'ui-ext'
  name: "errant-mandrill-ui-ext"
spec:
  ports:
  - name: https
    port: 8443
    protocol: TCP
    targetPort: 443
  selector:
    app: "errant-mandrill"
    component: console
  type: NodePort
  externalIPs:    
    - 192.168.77.77
    - 192.168.77.78
    - 192.168.77.79

@irfanhabib
Copy link
Contributor Author

To test with the old format:

env:
    CLUSTER_ADMIN_PASSWORD: changeme
    DOMAIN: cf-dev.io
    UAA_ADMIN_CLIENT_SECRET: uaa-admin-client-secret
    UAA_HOST: uaa.cf-dev.io
    UAA_PORT: 2793
kube:
    external_ip: 192.168.77.77
    storage_class:
        persistent: persistent
    auth: rbac

save to old-scf-config.yaml and run helm with:

$ cd deploy/kubernetes
$ helm install console/ -f old-scf-config.yaml --dry-run --debug | grep -A18 'ui-ext'
  name: "errant-mandrill-ui-ext"
spec:
  ports:
  - name: https
    port: 8443
    protocol: TCP
    targetPort: 443
  selector:
    app: "errant-mandrill"
    component: console
  type: NodePort
  externalIPs:    
    - 192.168.77.77

@irfanhabib irfanhabib mentioned this pull request Apr 11, 2018
Merged
nwmac
nwmac approved these changes Apr 11, 2018
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 7f53436 into v2-master Apr 11, 2018
@nwmac nwmac deleted the support-new-scf-config branch April 11, 2018 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irfanhabib @cfdreddbot @nwmac