Fix issue around apps and routes missing from space entity #1447
Conversation
richard-cox
commented
Jan 25, 2018
richard-cox
commented
- Missing apps and routes from space entity resulted in CF pages failing to load (no error on page, generic error in console)
- Could be missing due to the space entity being supplied from a request without inline depth OR apps/routes count more than 50
- In most cases we catch this. For some get count like functions we weren't handling this well
- This was an issue if any space OTHER than the first had over 50 apps or spaces
- We now handle these cases correctly
- Missing apps and routes from space entity resulted in CF pages failing to load (no error on page, generic error in console) - Could be missing due to the space entity being supplied from a request without inline depth OR apps/routes count more than 50 - In most cases we catch this. For some get count like functions we weren't handling this well - This was an issue if any space OTHER than the first had over 50 apps or spaces - We now handle these cases correctly
|
Hey richard-cox! Thanks for submitting this pull request! All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions. Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look. |
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
|
Closing + reopenning as per cfdreddbot instructions |
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
